uiv-lib / uiv

Bootstrap 3 components implemented by Vue.js.
https://uiv.wxsm.space
MIT License
944 stars 182 forks source link

fix: popover opening with new slot syntax and no title/content #840

Open damirbogdanov opened 1 year ago

damirbogdanov commented 1 year ago

Is this a bug fix or enhancement? - bug fix

Hello again! 👋

Once again, I appreciate all the hard work that's gone into this project. We're still happily using version 1. 😊

As we transitioned away from deprecated Vue slot syntax, we discovered some nuances with the popover component.

The Fix

The issue revolved around the isNotEmpty method. Previously, it checked for this.$slots.popover, which was causing problems with the latest Vue slot syntax. To address this, I've updated it to this.$scopedSlots.popover. This ensures that the popover functions as expected with the updated syntax. I've also added a unit test to cover this specific use case.

Is there a related issue?

None at this time.

Any Breaking Changes?

No breaking changes are introduced by this PR.