uiwjs / react-codemirror

CodeMirror 6 component for React. @codemirror https://uiwjs.github.io/react-codemirror/
https://uiwjs.github.io/react-codemirror/
MIT License
1.69k stars 134 forks source link

Add background image option to createTheme() #575

Closed ethan-vanderheijden closed 1 year ago

ethan-vanderheijden commented 1 year ago

In all READMEs and the theme editor page, I added backgroundImage: '', to show people that the option exists. I don't think we need a background image customizing option on the theme editor page (a text box would look weird next to the color selectors), but let me know if you think otherwise.

jaywcjlove commented 1 year ago

@Ethan-Vanderheijden I agree with this perspective. Adding a background image customizing option next to the color selectors on the theme editor page might not be visually appealing. Thus, I agree that it is unnecessary to include a text box for background image customization on the theme editor page.