Open trusktr opened 11 months ago
@trusktr upgrade v4.21.21
, I fixed this bug.
I am still running into this issue when using bbeditInit
or githubLightInit
and customizing the lineHighlight
property.
here is the relevant output of npm list
:
├── @uiw/codemirror-theme-bbedit@4.21.21 ├── @uiw/codemirror-theme-github@4.21.21 ├── @uiw/codemirror-theme-material@4.21.21 ├── @uiw/react-codemirror@4.21.21
@Danish-Dsouza It looks like the problem has been solved.
@jaywcjlove Maybe I am doing something wrong. Here is a screenshot of my editor. I have the first instance of single_employee
selected, and you can see the match highlights.
Here is my code.
<CodeMirror
height="auto"
minHeight="50px"
theme={bbeditInit({
settings: {
fontFamily: 'IBM Plex Mono',
selection: '#CDE2F2',
lineHighlight: '#FCFCFC',
background: '#FFFFFF',
gutterBackground: '#FFFFFF',
caret: '#000000',
gutterActiveForeground: '#000000',
gutterForeground: '#8D8D8E',
selectionMatch: '#CDE2F2',
},
})}
// and more stuff unrelated to styling
/>
@trusktr lineHighlight
must be a semi-transparent color value
- lineHighlight: '#FCFCFC',
+ lineHighlight: "#c7c7c76e",
- lineHighlight: '#FCFCFC', + lineHighlight: "#c7c7c76e",
D'oh, I will fix it! Thanks for the help and maintaining the library!
Hello! I get the same problem with these themes as here:
https://github.com/vadimdemedes/thememirror/issues/8#issuecomment-1826283539
I cannot see the selection on the current line.
Is it related to that update that @marijnh mentioned there?
Here's what I see:
https://github.com/uiwjs/react-codemirror/assets/297678/101cbacb-7456-408f-89da-36f64e5fc036
(That's the Noctis Lilac theme)