uiwjs / react-markdown-editor

A markdown editor with preview, implemented with React.js and TypeScript.
https://uiwjs.github.io/react-markdown-editor
MIT License
336 stars 34 forks source link

Rename show preview by default prop name #227

Open HarshDobariya79 opened 2 months ago

HarshDobariya79 commented 2 months ago

Current Scenario

Changes

jaywcjlove commented 2 months ago

@HarshDobariya79 Do you think changing visible to livePreview would be appropriate?

HarshDobariya79 commented 2 months ago

@HarshDobariya79 Do you think changing visible to livePreview would be appropriate?

Maybe we should come up with something else, because someone might think this prop disables the live preview at all if given false. Maybe defaultPreview or something.

HarshDobariya79 commented 1 month ago

@jaywcjlove what do you think, will this issue help the community?

jaywcjlove commented 1 month ago

@jaywcjlove what do you think, will this issue help the community?

Your suggestion is very helpful to the community, and I believe your idea aligns with the props of another component I’m working on. However, I currently don’t have the capacity to address this issue. I maintain many projects, and due to personal financial constraints, I can only prioritize my macOS applications and those supported by donations. Nevertheless, I will try to fix bugs if they arise, but for optimizations, I would appreciate it if you could submit a PR. Thank you! @HarshDobariya79

image