search

uiwjs / react-markdown-preview

React component preview markdown text in web browser. The minimal amount of CSS to replicate the GitHub Markdown style. Support dark-mode/night mode.
https://uiwjs.github.io/react-markdown-preview
MIT License
272 stars 48 forks source link

Error when upgrading to version 2.0.0 #42

Closed Timunas closed 3 years ago

Timunas commented 3 years ago

I started using your project recently and I installed the new version today, but I get this error when rendering the component.

Uncaught TypeError: combine is not a function

Screenshot from 2020-12-08 19-05-05

It is happening with version 2.0.0 and 2.1.0. So I believe the issue was probably introduced with the react-markdown update.

I tried downgraded to version 1.0.9 and it is working ok.

jaywcjlove commented 3 years ago

@Timunas May be caused by this reason: https://github.com/webpack/webpack/issues/4742

jaywcjlove commented 3 years ago

@Timunas https://github.com/remarkjs/react-markdown/issues/518

Waiting to upgrade dependencies.

micromark@2.10.1 => micromark@2.11.0

├─┬ @uiw/react-markdown-preview@2.1.1
│ ├─┬ react-markdown@5.0.3
│ │ └─┬ remark-parse@9.0.0
│ │   └─┬ mdast-util-from-markdown@0.8.3
│ │     └── micromark@2.10.1
│ └─┬ remark-gfm@1.0.0
│   └─┬ micromark-extension-gfm@0.3.2
│     ├── micromark@2.11.0  deduped
Timunas commented 3 years ago

@jaywcjlove I updated to 2.1.1. And now it is working fine.