uiwjs / react-md-editor

A simple markdown editor with preview, implemented with React.js and TypeScript.
https://uiwjs.github.io/react-md-editor
MIT License
2.17k stars 156 forks source link

Toolbar not working after updated to v2.1.3 #101

Closed raaynaldo closed 3 years ago

raaynaldo commented 3 years ago

preview="preview" is working fine, but suddenly when I use the toolbar there is not markdown syntax rendered to the text area.

https://codesandbox.io/s/markdown-editor-for-react-99-7ulng

jaywcjlove commented 3 years ago

@raaynaldo Did not understand what it meant.

raaynaldo commented 3 years ago

@jaywcjlove When I click bold, italic, or everything in the toolbar, it doesn't work. In sandbox link also didn't work. https://codesandbox.io/s/markdown-editor-for-react-99-7ulng

jaywcjlove commented 3 years ago

@raaynaldo The old version style import in the example and I have deleted it.

Old Style: https://unpkg.com/@uiw/react-md-editor@1.6.0/dist/markdown-editor.css

jaywcjlove commented 3 years ago

image

jaywcjlove commented 3 years ago

image

raaynaldo commented 3 years ago

@jaywcjlove sorry, I think there is a misunderstanding. So if we click the bold button in the toolbar, it will be adding ****

react-md-editor(v2 1 2)

After fixing preview props v2.1.3, the toolbar not working at all.

react-md-editor(v2 1 4)

jaywcjlove commented 3 years ago

@raaynaldo Upgrade + @uiw/react-md-editor@2.1.5, thx!

raaynaldo commented 3 years ago

Hi thank you for the update, it is work now. However, I found another bug.

try to change to the last version in this sandbox https://codesandbox.io/s/markdown-editor-for-react-96-luk07?file=/index.js:0-578

when you change the value in the input box, it will not change the text area. :(

jaywcjlove commented 3 years ago

@raaynaldo thx! it's my fault...

jaywcjlove commented 3 years ago

@raaynaldo Upgrade + @uiw/react-md-editor@2.1.7

jaywcjlove commented 3 years ago

@raaynaldo Another minor problem was found. Upgrade + @uiw/react-md-editor@2.1.8 :(

raaynaldo commented 3 years ago

@jaywcjlove what the minor problem is about? Luckily, I just did my presentation about my project that utilized this library, and react-md-editor is doing well. I will share my app If I have already hosted it. Thank you so much for creating this library. You can close this issue if the issue is done.

jaywcjlove commented 3 years ago

@raaynaldo thx!