search

uiwjs / react-md-editor

A simple markdown editor with preview, implemented with React.js and TypeScript.
https://uiwjs.github.io/react-md-editor
MIT License
2.17k stars 156 forks source link

Remove browserslist "not dead" from package.json in v3.3.3 #449

Open saran13raj opened 1 year ago

saran13raj commented 1 year ago

Hi @jaywcjlove, we are restricted to use v3.3.3 because of react version and loader issues. But when we make a build of our CRA app we get into a build error caused by borwserslist 

ERROR in ./node_modules/@uiw/react-md-editor/lib/esm/components/Toolbar/index.css (./node_modules/css-loader/dist/cjs.js??ref--5-2!./node_modules/postcss-loader/src??ref--5-3!./node_modules/@uiw/react-md-editor/lib/esm/components/Toolbar/index.css)
    Module build failed (from ./node_modules/postcss-loader/src/index.js):
    BrowserslistError: Unknown browser query `dead`

We found that removing "not dead" from browsers list fixed the issue. Can we remove "browserslist": {} from package.json for this specific version or you could create a patch version fix for this?

jaywcjlove commented 1 year ago

@saran13raj upgrade v3.19.4

saran13raj commented 1 year ago

As I said in the previous comment we are restricted to use v3.3.3 because of our existing repo's React version. Any version installed beyond v3.3.3 will not work. @jaywcjlove

jaywcjlove commented 1 year ago

Published versions on npm cannot be modified

@saran13raj Maybe add configuration override browserslist in package.json

I can't reproduce your error.

saran13raj commented 1 year ago

@jaywcjlove I understand that published versions can't be modified. Configuration override for browserslist can't be done in this case because we're trying to override a config for a dependency package. All I'm asking is can you release a new patch version v3.3.8 with browserslist removed?

jaywcjlove commented 1 year ago

https://uiwjs.github.io/npm-unpkg/#/pkg/@uiw/react-md-editor@3.3.8/file/package.json

@saran13raj Upgrade v3.3.8