search

uiwjs / react-monacoeditor

Monaco Editor component for React.
https://uiwjs.github.io/react-monacoeditor/
MIT License
296 stars 25 forks source link

Perhaps its not a good idea to trigger 'registerCompletionItemProvider' with 'value' #161

Closed PisecesPeng closed 2 years ago

PisecesPeng commented 2 years ago

https://github.com/jaywcjlove/react-monacoeditor/blob/c83f9b2ed3adcb96aa9a4e4eadd05c0b9c92f96c/src/index.tsx#L136

大佬好, 感觉使用value去触发monaco.languages.registerCompletionItemProvider不是一个特别好的时机. 是不是可以调整下？

也许是我没有理解其中封装的逻辑. Best regards!

jaywcjlove commented 2 years ago

@PisecesPeng 优化非常好 👍 , 就是有点小瑕疵，我给修复了一下

Upgrade v3.5.5