search

ujamii / openimmo

OpenImmo library
GNU General Public License v3.0
44 stars 11 forks source link

Switch to PHP Attributes #83

Open ebitkov opened 9 months ago

ebitkov commented 9 months ago

In version 3.30.0 the serializer made the annotations optional in favor of attributes.

Since the API in this project still uses annotations, this change makes this project not work by default. You have to configure an annotation reader manually now. Currently looking into how to do that. (see comment)

Considering the latest changes in the PHP ecosystem the switch to attributes seems to be overdue.

mgrundkoetter commented 9 months ago

Thanks for pointing that out. First of all you are correct, attributes are pretty standard now, so very good point to use them here as well. The update you mentioned is a minor update of the package and they decided to introduce a "B/C Break" change with that. Not common and rather unexpected. So as quick fix, just fix this package in your composer.json to the old version. For a more sustainable solution, feel free to open a PR for this feature.

ebitkov commented 9 months ago

As discussed here, just requiring doctrine/annotations via Composer seems to do the trick for now (tested it in my project).

Maybe adding the requirement into the composer.json for now should be sufficient for a hotfix until the annotations are rewritten as attributes?