ujh / fountainpencompanion

Repository for https://www.fountainpencompanion.com
Other
33 stars 9 forks source link

Automatically assign pen brand #2361

Closed ujh closed 2 weeks ago

ujh commented 2 weeks ago

When the pen model background job updates the data, it also now kicks off the Pens::AssignBrand job that assigns a pen brand when none has been set, yet.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.51%. Comparing base (ee866ab) to head (8b8b7c8). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2361 +/- ## ========================================== + Coverage 65.37% 65.51% +0.14% ========================================== Files 277 278 +1 Lines 4736 4753 +17 Branches 159 159 ========================================== + Hits 3096 3114 +18 + Misses 1624 1623 -1 Partials 16 16 ``` | [Flag](https://app.codecov.io/gh/ujh/fountainpencompanion/pull/2361/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Urban+Hafner) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/ujh/fountainpencompanion/pull/2361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Urban+Hafner) | `45.11% <ø> (ø)` | | | [ruby](https://app.codecov.io/gh/ujh/fountainpencompanion/pull/2361/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Urban+Hafner) | `76.53% <100.00%> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Urban+Hafner#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.