ujjwalguptaofficial / JsStore

Simplifying IndexedDB with SQL like syntax and promises
http://jsstore.net/
MIT License
858 stars 110 forks source link

Order by multiple column is not working? #245

Closed vaishnavhiren1993 closed 3 years ago

vaishnavhiren1993 commented 3 years ago

image

Show error on the order property while adding multiple columns.

Error Message

Type '{ by: string; type: string; }[]' is missing the following properties from type 'OrderQuery': by, typets(2739) types.d.ts(54, 5): The expected type comes from property 'order' which is declared here on type 'SelectQuery' (property) order?: OrderQuery

idbSorting: false trypes as well.

Pls help me out

Versions: @angular/cli": "^8.0.6", "@angular/common": "^8.0.3", "@angular/compiler": "^8.0.3", "@angular/core": "^8.0.3", "jsstore": "^3.6.1", "typescript": "~3.4.3"

ujjwalguptaofficial commented 3 years ago

Convert the order query to any and issue should be fixed.

I will look into typing later.

On Tue, 14 Sep 2021, 3:35 pm hiren vaishnav, @.***> wrote:

[image: image] https://user-images.githubusercontent.com/11805630/133237667-9971310e-b11c-4947-98eb-d4572202cd36.png

Show error on the order property while adding multiple columns.

Error Message

Type '{ by: string; type: string; }[]' is missing the following properties from type 'OrderQuery': by, typets(2739) types.d.ts(54, 5): The expected type comes from property 'order' which is declared here on type 'SelectQuery' (property) order?: OrderQuery

idbSorting: false trypes as well.

Pls help me out

Versions: @angular/cli": "^8.0.6", @./common": "^8.0.3", @./compiler": "^8.0.3", @.***/core": "^8.0.3", "jsstore": "^3.6.1", "typescript": "~3.4.3"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ujjwalguptaofficial/JsStore/issues/245, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTOR55AO4YLSVHAYKOWNGTUB4M45ANCNFSM5D7Y2JUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

vaishnavhiren1993 commented 3 years ago

Thanks for the quick response,

How can I achieve this?

Order type declares in SelectQuery in node modules. Node_Module is in Git ignore so It didn't work while deploying. (Azure CI/CD)

Suggestion: Better to add in the same version order?: OrderQuery | OrderQuery[];

instead of any

Can we get these changes in the same version?

vaishnavhiren1993 commented 3 years ago

Answer pls

ujjwalguptaofficial commented 3 years ago

I don't understand, its the typing which helps you only during the development but while deployment type doesn't matter. It must be some issue with your deployment.

ujjwalguptaofficial commented 3 years ago

closing due to inactivity

vaishnavhiren1993 commented 3 years ago

Hello, I think you didn't get my point

vaishnavhiren1993 commented 3 years ago
 _                      _                 ____ _     ___ 
/ \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|

/ △ \ | ' \ / | | | | |/ _ | '| | | | | | | / _ | | | | (| | || | | (| | | | || |_ | | // __| ||_, |_,||_,|| __|__|| |/

Angular CLI: 12.2.10 Node: 14.18.0 Package Manager: npm 6.14.15 OS: win32 x64

Angular: 12.2.10 ... animations, cdk, cli, common, compiler, compiler-cli, core ... forms, language-service, platform-browser ... platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1202.10 @angular-devkit/build-angular 12.2.10 @angular-devkit/core 8.3.29 @angular-devkit/schematics 8.3.29 @schematics/angular 8.3.29 rxjs 6.6.2 typescript 4.2.3

"jsstore": "^4.3.7",

devDependencies "file-loader": "^6.2.0"

image image

This is a problem: image

If an order is IQrderQuery type then how could I do order by multiple column

Suggested solution:

image

Is there any other way to do?

vaishnavhiren1993 commented 3 years ago

Pls reopen

vaishnavhiren1993 commented 3 years ago

jsstore.zip Installed node_module/jsstore folder