search

ujjwall-R / Dree

One single package for visualization, debugging, and exploration of folder hierarchies
77 stars 19 forks source link

Prevent printing of hidden files or unnecessary files #25

Open ujjwall-R opened 1 year ago

ujjwall-R commented 1 year ago

eg node_modules, caches etc etc

Ruberald commented 1 year ago

How would you like to approach this problem? Excluding directories with a "." is trivial. Would you like to maintain a config file for the rest names? Or bake them into the program?

Also i suppose it would be good to have a flag to turn off that option.

Ruberald commented 1 year ago

@ujjwall-R made a PR with a possible solution I'll be pleased if you could take a look.

ujjwall-R commented 1 year ago

How would you like to approach this problem? Excluding directories with a "." is trivial. Would you like to maintain a config file for the rest names? Or bake them into the program?

Also i suppose it would be good to have a flag to turn off that option.

It sounds nice if we go forward with a config file with some default configurations. What do you say?

ujjwall-R commented 1 year ago

@ujjwall-R made a PR with a possible solution I'll be pleased if you could take a look.

I m looking into it

Ruberald commented 1 year ago

How would you like to approach this problem? Excluding directories with a "." is trivial. Would you like to maintain a config file for the rest names? Or bake them into the program?

Also i suppose it would be good to have a flag to turn off that option.

It sounds nice if we go forward with a config file with some default configurations. What do you say?

I'll try adding the flags and renaming the config file tomorrow. For the addition of more hidden directories it would probably be better to edit the config itself but I'll look into that too. Meanwhile I'll be pleased to be assigned to this issue.

Ruberald commented 1 year ago

@ujjwall-R I made the requested changes except for the addition of extra directories as i believe it would be more comfortable for both the developer and the user to just edit the .dreeignore file themselves.

ujjwall-R commented 1 year ago

Hey, Sorry I was busy with my academic commitments. I just reviewed the PR, Awesome work! I added a comment for recommended minor changes. Can you please do it?

Or you can make PR to a new branch I have made. I will try to refactor it. Branch: 25-prevent-printing-of-hidden-files

Ruberald commented 1 year ago

Hey, Sorry I was busy with my academic commitments. I just reviewed the PR, Awesome work! I added a comment for recommended minor changes. Can you please do it?

Or you can make PR to a new branch I have made. I will try to refactor it. Branch: 25-prevent-printing-of-hidden-files

I'm sorry but i don't think i can see the comment you mentioned, do you mind telling me where exactly? It's my first time doing PRs so i might have missed something.

ujjwall-R commented 1 year ago

Hey, Sorry I was busy with my academic commitments. I just reviewed the PR, Awesome work! I added a comment for recommended minor changes. Can you please do it? Or you can make PR to a new branch I have made. I will try to refactor it. Branch: 25-prevent-printing-of-hidden-files

I'm sorry but i don't think i can see the comment you mentioned, do you mind telling me where exactly? It's my first time doing PRs so i might have missed something.

Hey, Can you see it now? https://github.com/ujjwall-R/Dree/pull/29

ujjwall-R commented 1 year ago

Hey Nice work. Would you like to update the readme with the -a flag? I am creating another issue for that.