ujtcelvn / Ending_Extension_Mod

A fork of Historical Project Mod 0.4.6, a mod for Victoria 2 - Heart of Darkness 3.04
GNU General Public License v3.0
1 stars 1 forks source link

Inconsistencies in CBs given for Mughal and Sikh Empire Conquest Events #14

Open Xylephony opened 1 year ago

Xylephony commented 1 year ago

The event war the British get with the Sikhs, as well as the CB they get against the Mughals when the Mughal Emperor supports the Sepoy rebellion, are the Indian puppet CB rather than the Conquest CB received in HPM, at least for the player. The AI seems to still get the original conquest CB, which confuses me, but I saw the behavior myself both from the player side and how an AI handles the events.

Regardless, for the player this prevents them from properly annexing the Sikhs unless they get a lucky roll on the Doctrine of Lapse, and from taking the Empress of India decision. Both should likely be reverted to Conquest CBs for the player, but at a minimum should be for the Mughals since the Mughals were completely abolished following the rebellion rather than just revassalized.

ujtcelvn commented 1 year ago

I didn't change anything in the Anglo-Sikh war and Sepoy rebellion code though, it's all the original HPM code. The death of Ranjit Singh event chain gives the UK 2 options:

  1. Get a make puppet CB
  2. Begin a war against the Sikh to annex them The AI will usually pick to annex the Sikh, but if the player is playing as the Sikh, the AI will choose to get a make puppet CB. If the player is playing as the UK, are still allowed to pick option 2 and get the conquest cb.

The same is true for the Mughal independence event. If the player is the Mughals, a AI UK won't choose to annex them, but a player UK can do whatever it wants and choose to annex them.

In conclusion, a player UK IS allowed to choose to annex the Sikh and the Mughals, it's that the AI won't choose to do so if YOU are the one playing as the Sikhs and the Mughals.

Xylephony commented 1 year ago

In conclusion, a player UK IS allowed to choose to annex the Sikh and the Mughals, it's that the AI won't choose to do so if YOU are the one playing as the Sikhs and the Mughals.

Ah, I see what happened. The option is to go to war immediately with conquest, or get a Puppet CB but not declare the war instantly. It was my fault for not reading it more closely, but that's still a confusing setup because you wouldn't think the CBs would be different; it makes sense for one option to declare war instantly and for the other to just give you the CB and let you use it when you want to, right?

I'd recommend making it so either both declare the war immediately or both give you the CB and let you choose to declare the war when you wish, so it's more obvious that the CB you get is the part which is different. I'd actually prefer the former option.