search

uk-fci / nhs-number

Python package to provide utilities for NHS Numbers, including validity checks, normalisation, and generation.
https://nhs-number.uk-fci.tech/
MIT License
6 stars 6 forks source link

Mixture of unittest and pytest tests #15

Closed andylaw closed 1 year ago

andylaw commented 1 year ago

We should settle on one option and just stick to that. I have no preference so we should go with whichever is the current flavour-du-jour and best supported

pacharanero commented 1 year ago

We have been using pytest a lot in our other projects so I would favour switching to that. It seems to be more popular at the moment. However one of the reasons it is more popular is that as well as adding helpful features, it can also run any unittest syntax tests as well, so there is no reason other than tidiness - which is a good reason IMO - to change the unittest stuff.

eatyourpeas commented 1 year ago

I agree. Pytest is great.

andylaw commented 1 year ago

Addressed by Pull Request #18