Closed pacharanero closed 1 year ago
I think normalise() is better. Or standard_format() might be even clearer, but normalise() for sure works.
I vote standardise_format()
. On reflection, normalisation is a statistical process and there will be dozens of packages with their own normalise()
functions. I prefer standardise_format()
over standard_format()
because my head mostly prefers function names to be "active"
The logical additional change will then be to rename the file from normalise.py
to standardise.py
How about just standardise()
?
I agree with preferring functions with 'active' names.
Also agree that normalise()
(ation) is a statistical/database related term.
Options are:
normalise_number()
normalise()
standardise_format()
standardise()
We could cater for more than one of the above by 'wrapping' function()
in function_alternate_name() which calls function() with the same parameters. This might help us avoid breaking the current API for any existing users.
I prefer the explicitness of standardise_format()
. See Pull Request #20
It's pretty obvious throughout that we are dealing with a number, so the
_number
bit innormalise_number()
is tautologous. I think from an external API point of view it is neater. Any objections to renamingnormalise_number()
tonormalise()
? Or, we could alias it, so that callingnormalise_number()
callsnormalise()
, and then users can choose.