search

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
33 stars 11 forks source link

Impurity Radiation Models #1012

Open jonmaddock opened 4 years ago

jonmaddock commented 4 years ago

In GitLab by @asbrown on Feb 14, 2020, 17:13

Summary

There are currently two impurity radiation models in PROCESS: the first calculates the impurity radiation in the core of the plasma; while the second calculates the impurity radiation for the divertor region. Each model calculates the same impurity radiation and draws from separate impurity radiation tables, each from Martin O'Mullane, which are effectively the same.

This is a duplication models and data which when resolved will simplify PROCESS by reducing unnecessary code and removing redundant files/folder.

Checklist

After implementing issue do the following

jonmaddock commented 2 years ago

In GitLab by @wg7580 on Jul 20, 2022, 15:26

closed

jonmaddock commented 2 years ago

In GitLab by @mkovari on Jul 21, 2022, 13:14

Hi Sam @wg7580 - Why did you close this one?

jonmaddock commented 2 years ago

In GitLab by @wg7580 on Jul 21, 2022, 14:13

reopened

jonmaddock commented 1 year ago

In GitLab by @timothy-nunn on May 25, 2023, 17:18

lz_non_corona_14_elements/*.dat has sections for 5 tau parameters (0.1, 1, 10, 100, 1000) and one for "in equilibrium - infinite confinement". Which of these does the impuritydata files correspond to? Because the data in impuritydata just provides Te, Lz, Z and does not provide a tau value. @mkovari

jonmaddock commented 1 year ago

In GitLab by @mkovari on May 26, 2023, 08:35

I think that the data in the folder /process/data/impuritydata is used by the main chamber radiation model, and the data in the folder process/data/lz_non_corona_14_elements is used by the Kallenbach model. I seem to recall that we never got round to reconciling the two to use the same data.

The Kallenbach model allows the user to choose the value of tau. The main chamber radiation model doesn't. According to Hanni's paper,

The ADAS loss function data described in Section 2.1.3 has been derived assuming a local coronal equilibrium or local ionisation equilibrium.

This implies that tau is infinite.

jonmaddock commented 1 year ago

In GitLab by @timothy-nunn on May 26, 2023, 08:53

Perfect. The process/data/lz_non_corona_14_elements does include tau infinite (the "in equilibrium - infinite confinement" section) if im not mistaken. I will try and replace the main chamber radiation model to use that.

jonmaddock commented 1 year ago

In GitLab by @timothy-nunn on Jun 21, 2023, 11:32

created merge request !923 to address this issue