ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
35 stars 11 forks source link

Sliding joints resistive heating error #1265

Closed jonmaddock closed 2 months ago

jonmaddock commented 3 years ago

In GitLab by @skahn on Feb 18, 2021, 15:45

Description

The sliding joint resitive heating was wrong.

Instead of joints in //

        ! Sliding joints resistive heating
        ! ---
        if ( i_cp_joints /= 0 ) then

            ! Total number of contact area (4 joints section per legs)
            n_contact_tot = 4 * n_tf_joints_contact* n_tf_joints * nint(n_tf_turn) * nint(n_tf)

            ! Total area of joint contact
            a_joints = tfthko * th_joint_contact * dble(n_contact_tot)

            ! joints resistive power losses
            pres_joints = rho_tf_joints * ritfc**2 / a_joints
        else 
            ! Joints resistance to be evaluated for SC
            pres_joints = 0.0D0
        end if
        ! ---

The joints must be in series

        ! Sliding joints resistive heating
        ! ---
        if ( i_cp_joints /= 0 ) then

            ! Number of contact area per joint (all legs)
            n_contact_tot = n_tf_joints_contact * nint(n_tf_turn) * nint(n_tf)

            ! Area of joint contact (all legs)
            a_joints = tfthko * th_joint_contact * dble(n_contact_tot)

            ! Total joints resistive power losses
            pres_joints = dble(n_tf_joints) * rho_tf_joints * ritfc**2 / a_joints
        else 
            ! Joints resistance to be evaluated for SC
            pres_joints = 0.0D0
        end if
        ! ---

Cheers
Seb

mkovari commented 3 months ago

I am not sure anyone is ever likely to use the resistive coil model (although I thought that before and then Seb came along and spent months on it).

stuartmuldrew commented 2 months ago

This change has already been made in sctfcoil.py (if loop at line 1862)