search

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
36 stars 11 forks source link

Fix Sankey Power accounting errors #1266

Closed jonmaddock closed 1 year ago

jonmaddock commented 3 years ago

In GitLab by @cjwgriesel on Feb 22, 2021, 18:07

Summary

On creating a Sankey diagram there is a discrepancy in the blanket calculation and in the recirculation calculation when CRYO AL magnets are selected. This is in the python script sankey_func.py

Steps to reproduce

The discrepancy in the blanket calculation is always there. It was noticed when High power net electric machines were being modelled. SCR 1.5GW Net electric power typically produces an error of the order of 7MW. It is because at 100MW net electric the error is small. This error is due to the variable pnucshld not being included in the calculation.

If a CRYO Aluminium resistive magnet is used there will be an error in the Sankey diagram for the recirculation Power it is caused by the extra pumping power required for the coolant flow in the Central Post. This is in the python script sankey_func.py. The variable for the extra pumping power is ppumpmw.

Checklist

After fixing bug do the following

jonmaddock commented 3 years ago

In GitLab by @cjwgriesel on Feb 22, 2021, 18:07

changed due date to March 01, 2021

jonmaddock commented 3 years ago

In GitLab by @cjwgriesel on Feb 23, 2021, 09:26

created branch 1265-fix-sankey-power-accounting-errors to address this issue

jonmaddock commented 3 years ago

In GitLab by @stuartmuldrew on Mar 8, 2021, 09:31

closed via merge request !386

jonmaddock commented 3 years ago

In GitLab by @stuartmuldrew on Mar 8, 2021, 09:32

mentioned in commit 2e6269b03d1b10ab46116c8dfdd71750a0f5dfff