ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
36 stars 11 forks source link

Investigate and remove superseded blanket switches #1538

Open jonmaddock opened 2 years ago

jonmaddock commented 2 years ago

In GitLab by @js0164 on Jan 24, 2022, 17:16

The table below lists the current blanket switches. Modify so that only iblanket switch is required.

name notes/comments description value effect
blktmodel default = 0; #TODO: this needs investigating and removing after any required functionality is in iblanket switch for blanket/tritium breeding model (see iblanket) 0 original simple model
blktmodel 1 KIT model based on a helium-cooled pebble-bed blanket (HCPB) reference design
blkttype #TODO: this needs to be merged into iblanket and then removed. switch for blanket type 1 WCLL; efficiency taken from WP13-DAS08-T02, EFDA_D_2M97B7
2 HCLL; efficiency taken from WP12-DAS08-T01, EFDA_D_2LLNBX
3 HCPB; efficiency taken from WP12-DAS08-T01, EFDA_D_2LLNBX
iblanket default = 1 switch for blanket model 1 CCFE HCPB model
iblanket 2 KIT HCPB model
iblanket 3 CCFE HCPB model with Tritium Breeding Ratio calculation
iblanket 4 KIT HCLL model
jonmaddock commented 2 years ago

In GitLab by @js0164 on Jan 24, 2022, 17:23

See #310 for blktmodel comment.

jonmaddock commented 2 years ago

In GitLab by @js0164 on Apr 6, 2022, 17:21

Removed from fispact and costs but:

chris-ashe commented 3 weeks ago

Having looked at the current state of the code there is a lot of interplay for all of the availability models and the stellarator models, of which the dependencies need to be fully understood. Since this issue is purely syntactic it may be best to tackle when more of the pythonisation has occurred and or when the blanket models are reviewed and fully understood.