water_use.py cooling_water_body using final evapvol in final calculations

[jonmaddock]

In GitLab by @timothy-nunn on Jun 17, 2022, 10:09

At the end of the icool loop in cooling_water_body, the following comment is made:

 water_usage_variables.evapvol = (
   wastetherm * water_usage_variables.volperenergy
)

# using this method the estimates for pond, lake and river evaporation produce similar results,
#   the average will be taken and used in the next stage of calculation
evapsum = evapsum + water_usage_variabl

Outside of the loop the following then occurs:

# water volume withdrawn from external source depends on recirculation or 'once-through' system choice
#   Estimated as a ratio to evaporated water (averaged across obervered dataset)
#   as per Diehl et al. USGS Report 2014–5184, http://dx.doi.org/10.3133/sir20145184

# recirculating water system:
water_usage_variables.wateruserecirc = 1.0e0 * water_usage_variables.evapvol

# once-through water system:
water_usage_variables.wateruseonethru = 98.0e0 * water_usage_variables.evapvol

however, based upon the comments, I believe the final two calculations should use the mean of evapsum not water_usage_variables.evapvol which is just the latest value (when icool=3) and does not take into account the water_usage_variables.evapvol when icool=1,2.

[jonmaddock]

In GitLab by @cz1743 on Jun 21, 2022, 11:43

created merge request !756 to address this issue

[jonmaddock]

In GitLab by @timothy-nunn on Jun 22, 2022, 09:24

closed via merge request !756

[jonmaddock]

In GitLab by @timothy-nunn on Jun 22, 2022, 09:24

mentioned in commit 242af697fafcc5a5ff24117e770fcc5c0ae4c8f1