search

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
36 stars 11 forks source link

Issue 1132 resistive model stability - [merged] #2180

Closed jonmaddock closed 1 year ago

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 13, 2020, 10:23

Merges issue-1132-resistive-model-stability -> develop

Last staking merge

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 13, 2020, 10:24

added 2 commits

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 13, 2020, 14:16

added 1 commit

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 19, 2020, 18:47

added 4 commits

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 19, 2020, 19:13

added 3 commits

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:28

added 1 commit

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:32

Commented on source/fortran/caller.f90 line 202

Justification :

If ST designs (itart == 1) with SC magnets (i_tf_sup == 1), the subroutine calculating the resitive CP cooling physics (cntrpst) should not be called.

commit : https://git.ccfe.ac.uk/process/process/-/commit/d887bbd7ffee5706ce9e42df5c840f7e710e2891

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:43

Commented on source/fortran/constraint_equations.f90 line 267

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:44

Commented on source/fortran/constraint_equations.f90 line 951

Get the comment captured by ford

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:44

Commented on source/fortran/constraint_equations.f90 line 2871

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:45

Commented on source/fortran/global_variables.f90 line 355

The constraints look at the center to pedestal top ratio

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:47

Commented on source/fortran/global_variables.f90 line 2758

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141

Changing the t_turn to t_turn_tf to avoid confusion with t_turn_cs

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 09:48

Commented on source/fortran/global_variables.f90 line 2770

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 10:03

Commented on source/fortran/global_variables.f90 line 4159

Adding a user input to specify how the TF CP top radius is parametrized.
This have been added to avoid unwanted bugs.

Related issue : https://git.ccfe.ac.uk/process/process/-/issues/1114

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:39

Commented on source/fortran/global_variables.f90 line 4171

The -1 value was used to specify that the CP radius should be calculated using the vertical build, or directly set (r_cp_top). However it was buggy ...

The parametrization method is nor set using i_r_cp_top, and f_r_cp has now a default value.

Related issue : https://git.ccfe.ac.uk/process/process/-/issues/1114

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:40

Commented on source/fortran/initial.f90 line 43

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1148

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:40

Commented on source/fortran/initial.f90 line 235

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1148

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:44

Commented on source/fortran/initial.f90 line 820

If the user sets the r_cp_top parameter or use it as an iteration variable, and does not use the corresponding paramertrization option, a lvl 3 error activated proposing to use i_r_cp_top = 1

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1148

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:48

Commented on source/fortran/initial.f90 line 1011

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

The turn is re-calculated if not input t_turn_tf = 0.

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:52

Commented on source/fortran/input.f90 line 1631

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1114

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:53

Commented on source/fortran/input.f90 line 1993

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:53

Commented on source/fortran/input.f90 line 2000

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:54

Commented on source/fortran/input.f90 line 1033

Uncommented changes has been made to allign the lines, in order to have a nice editor wrapping.

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:54

Commented on source/fortran/iteration_variables.f90 line 4001

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:54

Commented on source/fortran/iteration_variables.f90 line 4039

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:55

Commented on source/fortran/iteration_variables.f90 line 4227

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:55

Commented on source/fortran/iteration_variables.f90 line 4323

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:55

Commented on source/fortran/iteration_variables.f90 line 4522

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1141
Commit : https://git.ccfe.ac.uk/process/process/-/commit/bd763fe5bee9c9899f654e18bb1502fd22f55b74

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 11:57

Commented on source/fortran/machine_build.f90 line 139

Option 0 : R cp top is calculated with the position of the X-point, and set to 1.01 the mid-plane radius if calculated to a smaller value.

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1114

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 12:01

Commented on source/fortran/machine_build.f90 line 158

User specified r_cp_top. Corrected if too small with associated lvl 2 error.

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1114

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 12:10

Commented on source/fortran/tfcoil.f90 line 190

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1132

Use a separated variable for the average ccolant tempearture and the film temperature

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 12:10

Commented on source/fortran/tfcoil.f90 line 292

Bug fix : This property, used to calculate the average film temperature temperature difference, was effectively using the maximum temperature ...

Be explicit that we use the coolant average temperature. Issue : https://git.ccfe.ac.uk/process/process/-/issues/1132

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 12:12

Commented on source/fortran/tfcoil.f90 line 298

Bug fix : This property, used to calculate the average film temperature temperature difference, was effectively using the maximum temperature ...

Be explicit that we use the coolant average temperature. Issue : https://git.ccfe.ac.uk/process/process/-/issues/1132

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 12:12

Commented on source/fortran/tfcoil.f90 line 324

The aluminium thermal conductivity is now calculated in a separate sub-routine for clarity.

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1132

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 12:14

Commented on source/fortran/tfcoil.f90 line 663

Issue : https://git.ccfe.ac.uk/process/process/-/issues/1132

Thermal conductivity property subroutine. The fit is now extended up to 150 and it won't lead to negative values if T > 150.

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 12:17

added 1 commit

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 15:03

added 1 commit

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @skahn on Oct 20, 2020, 15:14

added 1 commit

Compare with previous version

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 16:15

Commented on source/fortran/caller.f90 line 202

I will add a thumbs up emoji to Seb's comments on code that I have reviewed and looks OK.

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 18:27

Commented on source/fortran/global_variables.f90 line 2773

Please state the unit in the comment line.

Also, "turn squared dimension" is not clear.

"Winding pack" would be clearer than WP.

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 18:33

Commented on source/fortran/global_variables.f90 line 4159

You might want to use some grammar in this sentence:

Switch selecting the TF CP is parametrization (ST only)

(and some vocabulary)

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 18:37

Commented on source/fortran/global_variables.f90 line 4164

This is not clear. What is the user supposed to do with this information? Perhaps, "The centrepost radius is set by the inner radius of the plasma, with a clearance given by ....."

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 18:45

Commented on source/fortran/global_variables.f90 line 4141

If you are referring to the Toroidal Field Coil you might want to use the acronym "TFC", or the expression "TF coil" (here and throughout).

In any case, I don't know what you mean by the outer TF midplane radius. As you can't put diagrams into the Fortran, you should refer to a diagram in the gitpages.

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 19:25

Commented on source/fortran/initial.f90 line 1016

:thumbsup:

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 19:26

Commented on source/fortran/input.f90 line 1629

Unclear as mentioned above.

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 19:32

Commented on source/fortran/iteration_variables.f90 line 3980

I think this is a copy-paste error.

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 19:38

Commented on source/fortran/machine_build.f90 line 130

Do you have a diagram for this? And have you updated the 2-page summary to show this geometry?

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 20:03

Commented on source/fortran/machine_build.f90 line 142

Isn't the radius of the centrepost the same at the top and the bottom?

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 20:04

Commented on source/fortran/machine_build.f90 line 158

I don't know much about the centrepost code so I am just nodding here.

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 20:07

Commented on source/fortran/stellarator.f90 line 2300

Is this line new? The rounded corners are calculated exactly elsewhere.

jonmaddock commented 4 years ago

In GitLab by @mkovari on Oct 27, 2020, 20:11

Commented on source/fortran/tfcoil.f90 line 190

I suppose by "film temperature" you mean the surface temperature of the coolant pipes.

You can then distinguish this from the bulk coolant temperature.

When you say "average", do you mean the average of the coolant inlet and outlet?

You could then have, for example, the average bulk coolant temperature.