search

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
34 stars 11 forks source link

WIP: "Add Pedestal Europed Parameteristion" - [opened] #2443

Open jonmaddock opened 2 years ago

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Oct 29, 2021, 08:53

Merges 1405-add-pedestal-europed-parameteristion -> develop

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Oct 29, 2021, 10:27

Commented on source/fortran/physics_functions.f90 line 1100

Typo *tokamak

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Oct 29, 2021, 10:27

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Oct 29, 2021, 10:31

Commented on source/fortran/physics_functions.f90 line 1117

Please change the variable names and comment to say 'scaling reference' as opposed to SPR.

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Oct 29, 2021, 10:36

Commented on source/fortran/physics_functions.f90 line 1127

This loop should be rewritten in the form 1-(x/y)<1.0D-9 rather than as equal and not equal due to double precision. There is a function in PROCESS that can be used for this.

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Oct 29, 2021, 10:40

Commented on source/fortran/physics_variables.f90 line 342

Typo:
pedestal-top
tokamak

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Oct 29, 2021, 10:42

Commented on source/fortran/plasmod.f90 line 141

We don't modify PLASMOD usually. PLASMOD is using ieped=1 with its own routine and isn't designed for spherical tokamaks. Are these changes needed?

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Oct 29, 2021, 10:44

Commented on CMakeLists.txt line 17

Don't need this extra line.

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Oct 29, 2021, 10:45

We should add some catchers and level 2 errors to this that alert the user of when it goes out of range.

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Oct 29, 2021, 10:53

Commented on source/fortran/plasmod.f90 line 141

No, I have reverted the change. It was done when I was testing for errors in teped

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 2, 2021, 10:28

Commented on source/fortran/physics_functions.f90 line 1100

changed this line in version 3 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 2, 2021, 10:28

Commented on source/fortran/physics_functions.f90 line 1117

changed this line in version 3 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 2, 2021, 10:28

Commented on source/fortran/physics_functions.f90 line 1127

changed this line in version 3 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 2, 2021, 10:28

Commented on source/fortran/physics_variables.f90 line 342

changed this line in version 3 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 2, 2021, 10:28

Commented on CMakeLists.txt line 17

changed this line in version 3 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 2, 2021, 10:28

added 62 commits

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 2, 2021, 16:13

added 104 commits

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 3, 2021, 08:43

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 3, 2021, 08:59

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 3, 2021, 12:51

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 3, 2021, 16:16

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 4, 2021, 08:29

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 9, 2021, 13:49

added 4 commits

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 9, 2021, 13:53

added 13 commits

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Nov 9, 2021, 13:56

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Nov 9, 2021, 13:57

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 11, 2021, 12:59

added 23 commits

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Nov 11, 2021, 14:11

Commented on source/fortran/physics_functions.f90 line 1114

These need changing to real(dp)

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Nov 11, 2021, 14:12

Commented on source/fortran/physics_functions.f90 line 1136

Same change as start of if loop

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 11, 2021, 14:28

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 12, 2021, 09:36

Commented on source/fortran/physics_functions.f90 line 1114

changed this line in version 16 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 12, 2021, 09:36

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mkovari on Nov 12, 2021, 10:15

Commented on source/fortran/physics_functions.f90 line 1149

Very minor: I am not keen on using a single variable to represent two different physical quantities. It saves lines in declarations but can be confusing.

jonmaddock commented 2 years ago

In GitLab by @mkovari on Nov 12, 2021, 10:28

Commented on source/fortran/physics_functions.f90 line 1149

I think the units are wrong here. t_eped_scaling_spherical is in kPa. You can't divide that by ne/10^19 to get keV. In SI units,

P=n_ek_BT

Writing temperature in eV units,

P=n_e e (T/eV)

I think (and do slap me if I am wrong), that by coincidence you factor of 1e19 has nearly cancelled e=1.6e-19

jonmaddock commented 2 years ago

In GitLab by @mkovari on Nov 12, 2021, 10:37

Commented on source/fortran/physics.f90 line 4148

It would be nice to have a similar block for ieped=2.

jonmaddock commented 2 years ago

In GitLab by @mkovari on Nov 12, 2021, 10:43

Commented on source/fortran/physics.f90 line 4161

Minor: If ieped=1 or 2 then the pedestal temperature is an output, so it should have 'OP' in the output.

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 15, 2021, 11:52

Commented on source/fortran/physics.f90 line 4161

changed this line in version 17 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Nov 15, 2021, 11:52

added 2 commits

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @stuartmuldrew on Jan 7, 2022, 22:08

marked as a Work In Progress