search

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
35 stars 11 forks source link

Ratio of fusion power to input power equation out of date #245

Closed jonmaddock closed 1 year ago

jonmaddock commented 9 years ago

In GitLab by @smedley on Mar 24, 2015, 09:39

It seems that the equation used for calculating the ratio of fusion power to input power (i.e. the figure of merit when minmax = 2) is out of date.

Code (from evaluators.f90): case (2) ! fusion power / input power
fc = sgn * powfmw / (pinjmw + porbitlossmw + tfcpmw + ppump/1.0D6)

Rich has suggested that this equation should be updated, as the variables tfcpmw and ppump are not relevant for tokamaks with superconducting magnets.

jonmaddock commented 9 years ago

In GitLab by @pknight on Mar 24, 2015, 09:54

True, but tfcpmw and ppump are set to zero if the TF coils are superconducting. It saves having an if-statement.

jonmaddock commented 9 years ago

In GitLab by @mkovari on Mar 25, 2015, 15:06

This seems to be the ratio of a random collection of items.

I suggest we remove this figure of merit. @hlux @rkemp

jonmaddock commented 9 years ago

In GitLab by @mkovari on May 29, 2015, 14:15

I have replaced the label by "not used".
The code will still work, I think.

jonmaddock commented 9 years ago

In GitLab by @hlux on May 29, 2015, 14:24

So, currently there is an option that still works, but is not labelled so that no one knows what it was supposed to be doing and it was not exactly doing what you expected anyway? So I have not looked into whether it is worth keeping this, but I would suggest, either it should be kept in a meaningful way or should be erased from the code cleanly, because otherwise we just end up having lots of junk in our code that no one remembers what it was good for and it is still not being used.

jonmaddock commented 9 years ago

In GitLab by @mkovari on May 29, 2015, 14:30

PROCESS now stops with a useful message when minmax=2. The number "2" still exists, however, so there is a vacant space in the arrays.

jonmaddock commented 9 years ago

In GitLab by @mkovari on Jun 1, 2015, 08:39

mentioned in commit e1702874955ca91352c1c3ef63e274473e2645fc