Resolve "Convert safety.f90 to Python" - [merged] #2620

Closed jonmaddock closed 1 year ago

In GitLab by @wg7580 on Jun 7, 2022, 10:17

Merges 1673-convert-safety-f90-to-python -> develop

Closes #1673

In GitLab by @wg7580 on Jun 7, 2022, 10:41

added 1 commit

0e967a4d - Removing data block

Compare with previous version

In GitLab by @wg7580 on Jun 7, 2022, 11:29

Might be able to be removed- need to ask Alex. Only called once, and this call is hashed out

In GitLab by @wg7580 on Jun 8, 2022, 14:50

Spoken to James Morris- model can be rmevoed and stored in history to be re-added if necessary. The model (LOCA) is not in use and is only seen in the output.py and caller.py where it is hashed out along with FISPACT.

In GitLab by @wg7580 on Jun 8, 2022, 14:56

added 1 commit

e2281470 - Removal of safety.f90

Compare with previous version

In GitLab by @timothy-nunn on Jun 8, 2022, 15:29

Commented on process/caller.py line 195

You can probably remove this commented code and just keep the note that safety (LOCA) has been removed (and you can include FISPACT too since I removed it a few days back)

In GitLab by @timothy-nunn on Jun 8, 2022, 15:29

Commented on process/output.py line 162

"

In GitLab by @timothy-nunn on Jun 8, 2022, 15:30

Commented on source/fortran/safety.f90 line 161

I believe that this was the only place fispact_variables.f90 was used. Can you check if that is the case and, if so, remove fispact_variables.f90 too

In GitLab by @wg7580 on Jun 8, 2022, 16:07

Commented on process/caller.py line 195

changed this line in version 3 of the diff

In GitLab by @wg7580 on Jun 8, 2022, 16:07

resolved all threads

In GitLab by @wg7580 on Jun 8, 2022, 16:07

Commented on process/output.py line 162

changed this line in version 3 of the diff

In GitLab by @wg7580 on Jun 8, 2022, 16:07

added 1 commit