search

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
36 stars 11 forks source link

CS flux output - [opened] #2642

Open jonmaddock opened 2 years ago

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Jun 20, 2022, 15:19

Merges 1616-central-solenoid-in-non-inductive-case-2 -> develop

Closes #1616

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Jun 28, 2022, 15:16

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Jun 28, 2022, 15:40

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Jun 29, 2022, 11:37

image

@j-a-foster You mind just checking over this and that it is consistent with the image above?

jonmaddock commented 2 years ago

In GitLab by @j-a-foster on Jun 29, 2022, 13:04

Commented on process/pfcoil.py line 1551

If I'm reading the attached formula correctly, shouldn't the (b) at the end of the numerator be (a)? Either that or the a**2 at the beginning should be b**2? In the formula it's R_CS, which is at the beginning and end of the numerator.

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Jun 29, 2022, 13:56

Commented on process/pfcoil.py line 1551

changed this line in version 4 of the diff

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Jun 29, 2022, 13:56

added 1 commit

Compare with previous version

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Aug 10, 2022, 09:49

unassigned @mn3981

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Aug 10, 2022, 09:49

unmarked as a Work In Progress

jonmaddock commented 2 years ago

In GitLab by @ajpearcey on Aug 31, 2022, 12:17

Commented on process/pfcoil.py line 1550

Is this the same quantity that is calculated as ddics in pfcoil? If so why are they different by a extra factor pi? I suspect this implementation in this MR is correct, but can we just check?

Ignore me. this because rmu0 have the pi in it... Maybe we should change the name of ddics to cs_delta to make it consistent across the code? Also ddics is an awful variable name.

jonmaddock commented 2 years ago

In GitLab by @ajpearcey on Aug 31, 2022, 12:18

Commented on process/pfcoil.py line 2094

What is a "true" flux swing? I think this labelling is unclear. Is this meant to be the flux swing required for start up, estimated from the coils? Or have I misunderstood?

Additionally I can see the equations above have units Wb/s, but what is a Wb/s? Why does maximum flux swing mean here?

jonmaddock commented 2 years ago

In GitLab by @ajpearcey on Aug 31, 2022, 12:18

Commented on process/pfcoil.py line 1554

This expression does not involve the inductance between the CS coil and the plasma. Is that justified? If the major radius of the machine increases for a fixed magnetic field then surely I expect the available flux swing to decrease.

In addition have you considered the contributions from the PF coils the the start up flux swing?

jonmaddock commented 2 years ago

In GitLab by @ajpearcey on Aug 31, 2022, 12:24

Just some general comments here. A lot of these questions are to help me understand these eqautions.

Also, could you attach some example output to the issue (maybe use FSNF from the test scenarios) so we can have a look at how this behaves.

jonmaddock commented 2 years ago

In GitLab by @mn3981 on Aug 31, 2022, 14:02

Commented on process/pfcoil.py line 2094

From my memory it is called true flux swing as PROCESS will calculate how much swing the CS has to give for start-up based on how much the PF coils didn't take up. Meaning that PROCESS could easily say that a certain CS gives a un-realistic flux swing based on its configuration. So it is called true as it is more truthful to the flux it would actually generate in those conditions.