Remove bremsstrahlung and line radiation calculations

ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.

https://ukaea.github.io/PROCESS/

MIT License

26 stars 11 forks source link

Remove bremsstrahlung and line radiation calculations #3210

Closed ajpearcey closed 1 week ago

ajpearcey commented 3 weeks ago

This closes #1231 and #283

ajpearcey commented 1 week ago

This is now only failing the regression tests and is ready for review

mkovari commented 1 week ago

I have run the large-tokamak on this branch and compared it to the result using main, with significant differences. I think this is just because main has changed. Would you be able to merge main into your branch and push it back onto GitHub so they can be compared? @ajpearcey

ajpearcey commented 1 week ago

This code removal causes a change in the solution vector. This is because of check for a model inconsistency that pimp was not smaller than pbrem, which was being found. Now after removing pbrem calculation this can never be true.