ukaea / PROCESS

PROCESS is a systems code at UKAEA that calculates in a self-consistent manner the parameters of a fusion power plant with a specified performance, ensuring that its operating limits are not violated, and with the option to optimise to a given function of these parameters.
https://ukaea.github.io/PROCESS/
MIT License
36 stars 11 forks source link

Net electric output different based on cost model #729

Closed jonmaddock closed 1 year ago

jonmaddock commented 6 years ago

In GitLab by @stuartmuldrew on Jun 25, 2018, 10:52

The net electric power output is currently dependent on the cost model used. The contribution "All other internal electric power requirements (MW) (fachtmw)" is calculated in plant_power.f90:

!  Total baseline power to facility loads, MW
fcsht  = basemw + efloor*pkwpm2/1000.0D0
...
!  Facility heat removal (fcsht calculated in ACPOW)
fachtmw = fcsht

This is dependent on efloor (Effective floor area (m2)) which is zero if the new cost model is used.

Ref: @hlux @mkovari @jmorris-uk @kellis

jonmaddock commented 6 years ago

In GitLab by @hlux on Jun 25, 2018, 10:56

Okay, this sounds like we need to get (/copy) a model for the effective floor area, which needs to be included in the new cost model. @mkovari Was there a reason why efloor was zero in the new model? I assume not. Perhaps we can just copy the old model over to the new? @stuartmuldrew do you understand how efloor was calculated in the old model?

jonmaddock commented 6 years ago

In GitLab by @stuartmuldrew on Jun 25, 2018, 11:14

efloor is calculated in buildings.f90,

! Calculate effective floor area for ac power module
efloor = (rbv+rmbv+wsv+triv+elev+conv+cryv+admv+shov)/6.0D0

and is the sum of various buildings.

jonmaddock commented 6 years ago

In GitLab by @mkovari on Jul 17, 2018, 13:01

efloor is not calculated in the new cost model because the model is much more high level and doesn't use detailed numbers like this.

I agree that it would be good to adjust the code so that changing the cost model only changes the cost!

If you really want to do it as well as possible you could look at the ITER power requirements for heating, lighting, ventilation, air-conditioning, air filtration and detritiation etc, if you can find them.

jonmaddock commented 5 years ago

In GitLab by @stuartmuldrew on Feb 28, 2019, 09:34

mentioned in commit 4329cf95e96072d3f8c0b021de023a5a250a201c

jonmaddock commented 5 years ago

In GitLab by @jmorris-uk on Mar 14, 2019, 15:03

I see in commit 4329cf95 above you have added the buildings call for all cost models. So efloor should now always be calculated. I will close the issue.

jonmaddock commented 5 years ago

In GitLab by @jmorris-uk on Mar 14, 2019, 15:03

closed

jonmaddock commented 5 years ago

In GitLab by @stuartmuldrew on Mar 14, 2019, 15:24

@jmorris-uk efloor is now always calculated, however this is currently only on branch CostModel2. It has not yet been merged into develop.

jonmaddock commented 5 years ago

In GitLab by @jmorris-uk on Mar 14, 2019, 15:30

reopened

jonmaddock commented 5 years ago

In GitLab by @stuartmuldrew on Jul 23, 2019, 11:35

closed