search

ukaea / fair-mast-ingestion

Ingestion tool for the FAIR MAST project
1 stars 0 forks source link

Add support for CSD3 #3

Closed samueljackson92 closed 2 months ago

samueljackson92 commented 2 months ago

This removes the segfault handling code and adds jobscripts for CSD3.

To review:

Note use: 

python -m pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple uda

to upgrade uda

samueljackson92 commented 2 months ago

I had added your suggestions to the README.

jameshod5 commented 2 months ago

python -m pip install --U pip - This doesn't work for me, have to use --upgrade instead. (or change to -U instead)

other two comments are more suggestions, but the above needs to be fixed

This still needs to change to python -m pip install --upgrade pip or python -m pip install -U pip

samueljackson92 commented 2 months ago

Sorry missed that one!

jameshod5 commented 2 months ago

Looks good, merged

samueljackson92 commented 2 months ago

[heart] Jackson, Samuel (Computing) reacted to your message:

From: jameshod5 @.> Sent: Monday, August 19, 2024 7:55:21 AM To: ukaea/fair-mast-ingestion @.> Cc: Jackson, Samuel (Computing) @.>; Author @.> Subject: Re: [ukaea/fair-mast-ingestion] Add support for CSD3 (PR #3)

Looks good, merged

— Reply to this email directly, view it on GitHubhttps://github.com/ukaea/fair-mast-ingestion/pull/3#issuecomment-2295902746, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAS7LZJFZCGKYELEXYPOYQLZSGQGTAVCNFSM6AAAAABMSDDGAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVHEYDENZUGY. You are receiving this because you authored the thread.Message ID: @.***>