search

ukaea / neutronics_material_maker

A tool for making parametric material cards for use in neutronics codes. Original developed for the Paramak
19 stars 10 forks source link

Removing units from args #131

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

Arguments have been renamed to not contain units. This means there is just one way of setting the temperature and reduces the oppertunities for errors. Thanks @eepeterson for the suggestion

pressure_in_Pa -> pressure temperature_in_K -> temperature temperature_in_C -> removed

This is a breaking change so the docs and tests have also been updated.

The tutorial videos might need to be remade, but that can be done with another PR

codecov[bot] commented 3 years ago

Codecov Report

Merging #131 (72db0a9) into develop (210d029) will increase coverage by 0.08%. The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #131      +/-   ##
===========================================
+ Coverage    95.51%   95.60%   +0.08%     
===========================================
  Files            4        4              
  Lines          714      682      -32     
===========================================
- Hits           682      652      -30     
+ Misses          32       30       -2
Impacted Files Coverage Δ
neutronics_material_maker/material.py 95.42% <89.47%> (+0.05%) :arrow_up:
neutronics_material_maker/mutlimaterial.py 95.23% <100.00%> (+0.20%) :arrow_up:
neutronics_material_maker/utils.py 96.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 210d029...72db0a9. Read the comment docs.