ukaea / parallel-preprocessor

Parallel-preprocessor: a prototype of parallel CAE geometry preprocessing framework
Other
19 stars 10 forks source link

Fix behaviour for brep files without metadata #32

Closed johnnonweiler closed 3 years ago

johnnonweiler commented 3 years ago

When attempting to process a brep file which did not have an associated metadata file, there was an obscure error:

RuntimeError: [json.exception.type_error.302] type must be string, but is null

With this fix, there is now a warning that no metadata has been provided, and then PPP continues.

Checklist

qingfengxia commented 3 years ago

Andy has comment: Concurrent with this it would be good to have a flag that should allow or disallow continuation if no metadata is found

makeclean commented 3 years ago

I think it should fail is metadata is expected and no metatdata is found (maybe default) and then add a flag like --no-fatal or something like that?

qingfengxia commented 3 years ago

I think the current impl (With this fix, there is now a warning that no metadata has been provided, and then PPP continues.), give user the chance to eval imprint brep, for the first time, there is no metadata.

In the future , it can change to Andy's