search

ukaea / parallel-preprocessor

Parallel-preprocessor: a prototype of parallel CAE geometry preprocessing framework
Other
19 stars 10 forks source link

CMake build changes source folders and then stages those changes in git #33

Open johnnonweiler opened 3 years ago

johnnonweiler commented 3 years ago

In some circumstances, the cmake build will do a git submodule add https://github.com/pybind/pybind11 in the src/python folder. (See src/python/CMakeLists.txt)

I would expect the cmake build to normally only change files in the build folder (and not to stage changes in git).

makeclean commented 3 years ago

Concurrent with this it would be good to have a flag that should allow or disallow continuation if no metadata is found

From: johnnonweiler notifications@github.com Sent: Tuesday, December 15, 2020 4:03:29 PM To: ukaea/parallel-preprocessor parallel-preprocessor@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [ukaea/parallel-preprocessor] CMake build changes source folders and then stages those changes in git (#33)

In some circumstances, the cmake build will do a git submodule add https://github.com/pybind/pybind11 in the src/python folder. (See src/python/CMakeLists.txt)https://github.com/ukaea/parallel-preprocessor/blob/ac577dc8c8c16d8100f9325e14fb6d5122bc9618/src/python/CMakeLists.txt

I would expect the cmake build to normally only change files in the build folder (and not to stage changes in git).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ukaea/parallel-preprocessor/issues/33, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASTUSU3TQMKA7C2XBSUYADSU6CFDANCNFSM4U4R3YWA.

qingfengxia commented 3 years ago

if pybind11 is not found, it will download somehow.

I will change this soon later, by just git clone download to somewhere like third-party folder,