ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

added test matrix #760

Closed billingsley-john closed 3 years ago

billingsley-john commented 3 years ago

Proposed changes

PR to add matrix testing to github actions CI for different cadquery versions

Types of changes

What types of changes does your code introduce to the Paramak? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

shimwell commented 3 years ago

That was quick

codecov[bot] commented 3 years ago

Codecov Report

Merging #760 (60947fe) into develop (cf27ff1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #760   +/-   ##
========================================
  Coverage    95.38%   95.38%           
========================================
  Files           72       72           
  Lines         4724     4724           
========================================
  Hits          4506     4506           
  Misses         218      218           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf27ff1...60947fe. Read the comment docs.

shimwell commented 3 years ago

Looks like the simulations using stl files made in cadquery version 2.1 work and the stl files made in cadquery master version doesn't work.

billingsley-john commented 3 years ago

Looks like the simulations using stl files made in cadquery version 2.1 work and the stl files made in cadquery master version doesn't work.

I wonder at what point this stopped working. I suppose this managed to get through because the circle ci tests are pulling a static docker image - we are already seeing the benefits of this new testing approach.

billingsley-john commented 3 years ago

Currently, when one set of tests in the matrix fails, it causes the cancellation of the other tests in the matrix. I.e. if tests fail for master, the tests running for 2.1 are cancelled. We don't want this - we want to return pass/fail for both scenarios each time.

billingsley-john commented 3 years ago

Continued in #764