ukaea / paramak

Create parametric 3D fusion reactor CAD models

https://paramak.readthedocs.io/en/main/

36 stars 12 forks source link

added jupyter-cadquery to docker image #766

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

Proposed changes

This is a tiny addition to the Dockerfile. jupyter-cadquery has been added. This will update the dependencies image when merged into develop and allow the Circle CI testing in PR #756 to be run on a docker image with the correct python packages.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactoring
[ ] Documentation Update (if none of the other choices apply)
[ ] New tests

Checklist

[ ] Pep8 applied
[x] Unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

codecov[bot] commented 3 years ago

Codecov Report

Merging #766 (a0db509) into develop (8cfcded) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #766   +/-   ##
========================================
  Coverage    95.38%   95.38%           
========================================
  Files           72       72           
  Lines         4724     4724           
========================================
  Hits          4506     4506           
  Misses         218      218

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8cfcded...a0db509. Read the comment docs.

RemDelaporteMathurin commented 3 years ago

@Shimwell 2 neutronics tests seem to be failing in GA CI. (@billingsley-john it means the GA CI can fail afterall 😄 )

If I understood correctly, that workflow rebuilds the image from the Dockerfile and CircleCI doesn't. perhaps that's why CircleCI isn't failing. Does it run locally?

shimwell commented 3 years ago

@Shimwell 2 neutronics tests seem to be failing in GA CI. (@billingsley-john it means the GA CI can fail afterall smile )

If I understood correctly, that workflow rebuilds the image from the Dockerfile and CircleCI doesn't. perhaps that's why CircleCI isn't failing. Does it run locally?

Yep this passes all the tests locally when running on my base system. I should build the docker image and try that as well

RemDelaporteMathurin commented 3 years ago

@Shimwell 2 neutronics tests seem to be failing in GA CI. (@billingsley-john it means the GA CI can fail afterall smile ) If I understood correctly, that workflow rebuilds the image from the Dockerfile and CircleCI doesn't. perhaps that's why CircleCI isn't failing. Does it run locally?

Yep this passes all the tests locally when running on my base system. I should build the docker image and try that as well

The tests are failing in #767 too ... This probably means that a change has occured in the develop branch