ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

Update dockerfiles #771

Closed billingsley-john closed 3 years ago

billingsley-john commented 3 years ago

Proposed changes

PR which re-organises the docker build which occur on PRs.

On push/PR to develop:

On push/PR to main:

I.e. ukaea/paramak:dependencies and geometry-dependencies are built on both PRs to develop and main, so the image will be up-to-date with the most up-to-date of those branches.

All images build CQ2.1 which introduces stability into the paramak; however, this can be changed easily.

Types of changes

What types of changes does your code introduce to the Paramak? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 years ago

Codecov Report

Merging #771 (40a293c) into develop (15352ae) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #771   +/-   ##
========================================
  Coverage    95.42%   95.42%           
========================================
  Files           73       73           
  Lines         4762     4762           
========================================
  Hits          4544     4544           
  Misses         218      218           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15352ae...40a293c. Read the comment docs.

billingsley-john commented 3 years ago

Looks like another nice addition, just a few things code inspector picked up

Thank you for the suggestions! @Shimwell