ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

Test - Returning test results on GitHub Actions #776

Closed billingsley-john closed 3 years ago

billingsley-john commented 3 years ago

Proposed changes

Test PR for trialing ways to get github actions ci to return test results and fail with respect to them. (This will not be merged)

Types of changes

What types of changes does your code introduce to the Paramak? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 years ago

Codecov Report

Merging #776 (bbee63e) into develop (cf27ff1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #776   +/-   ##
========================================
  Coverage    95.38%   95.38%           
========================================
  Files           72       72           
  Lines         4724     4724           
========================================
  Hits          4506     4506           
  Misses         218      218           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf27ff1...bbee63e. Read the comment docs.

shimwell commented 3 years ago

Looks like code inspector has a few easy corrections, I can do them if you like

billingsley-john commented 3 years ago

Not working - will be revisited in the future