ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

Further TF Coil Fixes #782

Closed katie-taylor closed 3 years ago

katie-taylor commented 3 years ago

Proposed changes

Same issue as with TFCoilsRectangle, inner leg overlap causing construction error. Raised by issue #780

Types of changes

What types of changes does your code introduce to the Paramak?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

billingsley-john commented 3 years ago

All looks great, thanks very much for finding and fixing this issue!

codecov[bot] commented 3 years ago

Codecov Report

Merging #782 (8529c56) into develop (b0e8c9a) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #782   +/-   ##
========================================
  Coverage    95.25%   95.25%           
========================================
  Files           73       73           
  Lines         4782     4784    +2     
========================================
+ Hits          4555     4557    +2     
  Misses         227      227           
Impacted Files Coverage Δ
...tric_components/toroidal_field_coil_coat_hanger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0e8c9a...8529c56. Read the comment docs.

billingsley-john commented 3 years ago

Tests pass locally