search

ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

ToroidalFieldCoilPrincetonD R1 variable #787

Closed billingsley-john closed 3 years ago

billingsley-john commented 3 years ago

Currently, the R1 variable of this class corresponds to the distance to the furthest surface of the inner leg (from origin) - (i.e. the 'inner' surface of the inner leg from inside the coil). Outlined in #786, R1 should correspond to the nearest surface of the inner leg (from origin) - (i.e. the 'outer' surface of the inner leg from inside the coil), to be consistent with ToroidalFieldCoilTripleArc

shimwell commented 3 years ago

Thanks for discovering this, I guess there are a few things like this that go silently unnoticed for a while

billingsley-john commented 3 years ago

See #789

billingsley-john commented 3 years ago

Resolved in #789