Closed shimwell closed 3 years ago
Merging #788 (75b2f87) into develop (b47811f) will decrease coverage by
0.82%
. The diff coverage is32.81%
.
@@ Coverage Diff @@
## develop #788 +/- ##
===========================================
- Coverage 95.29% 94.47% -0.83%
===========================================
Files 74 75 +1
Lines 4828 4888 +60
===========================================
+ Hits 4601 4618 +17
- Misses 227 270 +43
Impacted Files | Coverage Δ | |
---|---|---|
...k/parametric_components/vacuum_vessel_inner_leg.py | 25.45% <25.45%> (ø) |
|
paramak/parametric_components/vacuum_vessel.py | 93.33% <75.00%> (-6.67%) |
:arrow_down: |
paramak/__init__.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b47811f...75b2f87. Read the comment docs.
Proposed changes
This PR is not ready to review
@katie-taylor and @billingsley-john have made a start on the new vacuum vessel with an inner leg
The code for this screen shot is
Still a few things to finish
Todo
Types of changes
What types of changes does your code introduce to the Paramak? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.