search

ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

TFCoilCasing vertical_section_offset #790

Closed billingsley-john closed 3 years ago

billingsley-john commented 3 years ago

vertical_section_offset parameter should specify total distance between vertical section and magnet, but outer_offset is also being added.

magnet = paramak.ToroidalFieldCoilPrincetonD(R1=80, R2=300, thickness=30, distance=30, number_of_coils=1) casing = paramak.TFCoilCasing(magnet=magnet, inner_offset=10, outer_offset=20, vertical_section_offset=10, distance=60)

Expected: Distance between vertical section and magnet = 10 Actual: Distance between vertical section and magnet = 30 (vertical_section_offset + outer_offset)

Screenshot from 2021-03-26 09-57-40

billingsley-john commented 3 years ago

See #789

billingsley-john commented 3 years ago

Resolved in #789