Closed shimwell closed 3 years ago
Merging #801 (e0ff1b0) into develop (d503b4c) will decrease coverage by
0.00%
. The diff coverage is0.00%
.:exclamation: Current head e0ff1b0 differs from pull request most recent head 157da70. Consider uploading reports for the commit 157da70 to get more accurate results
@@ Coverage Diff @@
## develop #801 +/- ##
===========================================
- Coverage 95.33% 95.33% -0.01%
===========================================
Files 74 74
Lines 5251 5250 -1
===========================================
- Hits 5006 5005 -1
Misses 245 245
Impacted Files | Coverage Δ | |
---|---|---|
paramak/neutronics_utils.py | 91.28% <0.00%> (-0.04%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d503b4c...157da70. Read the comment docs.
Proposed changes
A few more suggestions from the pull request review, we are down to just 27 remaining. Quite a few are due to varible names being too short.
Types of changes
What types of changes does your code introduce to the Paramak? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...