ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

Added solid for manifest files #805

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

Proposed changes

A small change that allows Reactor.solid to work for reactors made from a manifest.json file

Types of changes

Checklist

codecov[bot] commented 3 years ago

Codecov Report

Merging #805 (b0e13d6) into develop (1dd31c6) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #805      +/-   ##
===========================================
+ Coverage    95.33%   95.35%   +0.02%     
===========================================
  Files           74       74              
  Lines         5250     5253       +3     
===========================================
+ Hits          5005     5009       +4     
+ Misses         245      244       -1     
Impacted Files Coverage Δ
paramak/parametric_components/divertor_ITER.py 100.00% <100.00%> (ø)
paramak/reactor.py 91.38% <100.00%> (+0.30%) :arrow_up:
paramak/shape.py 98.23% <100.00%> (ø)
paramak/utils.py 99.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1dd31c6...b0e13d6. Read the comment docs.