Closed shimwell closed 3 years ago
Merging #829 (00ca6e5) into develop (b4567f1) will decrease coverage by
1.03%
. The diff coverage is56.19%
.:exclamation: Current head 00ca6e5 differs from pull request most recent head b8c892b. Consider uploading reports for the commit b8c892b to get more accurate results
@@ Coverage Diff @@
## develop #829 +/- ##
===========================================
- Coverage 95.27% 94.23% -1.04%
===========================================
Files 74 75 +1
Lines 5271 5345 +74
===========================================
+ Hits 5022 5037 +15
- Misses 249 308 +59
Impacted Files | Coverage Δ | |
---|---|---|
...aramak/parametric_reactors/eu_demo_2015_reactor.py | 100.00% <ø> (ø) |
|
paramak/parametric_reactors/iter_reactor.py | 100.00% <ø> (ø) |
|
paramak/parametric_reactors/sparc_paper_2020.py | 100.00% <ø> (ø) |
|
paramak/utils.py | 99.61% <ø> (ø) |
|
...k/parametric_components/vacuum_vessel_inner_leg.py | 25.45% <25.45%> (ø) |
|
paramak/parametric_components/vacuum_vessel.py | 93.54% <50.00%> (-6.46%) |
:arrow_down: |
paramak/neutronics_utils.py | 86.11% <81.81%> (-5.18%) |
:arrow_down: |
paramak/reactor.py | 91.80% <96.42%> (-0.05%) |
:arrow_down: |
paramak/__init__.py | 100.00% <100.00%> (ø) |
|
paramak/parametric_neutronics/neutronics_model.py | 93.72% <100.00%> (+0.08%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f649849...b8c892b. Read the comment docs.
Proposed changes
reflective surfaces were being prepended with "mat:" when using the pymoab export h5m method.
While most materials need prepending, reflective tags are a special case. So I've added special handling for that case
This tiny PR fixes the problem.
Types of changes
Checklist