ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
37 stars 12 forks source link

Tests fail with paramak:dependencies #838

Open RemDelaporteMathurin opened 3 years ago

RemDelaporteMathurin commented 3 years ago

When running a container on ukaea/paramak:dependencies, running pytest tests/test_Shape.py fails:

_________________________________________ ERROR collecting tests/test_Shape.py _________________________________________
ImportError while importing test module '/home/shared/tests/test_Shape.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/conda/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_Shape.py:8: in <module>
    import paramak
paramak/__init__.py:1: in <module>
    from .shape import Shape
paramak/shape.py:16: in <module>
    from paramak.neutronics_utils import (add_stl_to_moab_core,
paramak/neutronics_utils.py:15: in <module>
    from remove_dagmc_tags import remove_tags
E   ModuleNotFoundError: No module named 'remove_dagmc_tags'

Is it possible that this dependencies image is out of date or missing some dependencies?

RemDelaporteMathurin commented 3 years ago

@Shimwell It seems "remove_dagmc_tags" is not in the requirements.txt

shimwell commented 3 years ago

Thanks Remi. This is quite a new package and is part of the process for removing neutronics. I must have forgotten to put it in to the requirements.txt