ukaea / paramak

Create parametric 3D fusion reactor CAD models

https://paramak.readthedocs.io/en/main/

37 stars 12 forks source link

Reuse points between shapes #839

Closed RemDelaporteMathurin closed 3 years ago

RemDelaporteMathurin commented 3 years ago

Proposed changes

This fixes #751

Types of changes

What types of changes does your code introduce to the Paramak? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactoring
[ ] Documentation Update (if none of the other choices apply)
[ ] New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] Pep8 applied
[ ] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 years ago

Codecov Report

Merging #839 (fc0b0a9) into develop (79c2a04) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #839   +/-   ##
========================================
  Coverage    94.67%   94.67%           
========================================
  Files           75       75           
  Lines         5390     5393    +3     
========================================
+ Hits          5103     5106    +3     
  Misses         287      287

Impacted Files	Coverage Δ
paramak/shape.py	`97.86% <100.00%> (+<0.01%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79c2a04...fc0b0a9. Read the comment docs.

shimwell commented 3 years ago

Thanks Remi, this avoids modifying the input points so that they can be reused. This covers one of the problems with points which is really helpful. Happy to merge this if there are not objections.