ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
36 stars 12 forks source link

Optimise imports #840

Closed RemDelaporteMathurin closed 3 years ago

RemDelaporteMathurin commented 3 years ago

Proposed changes

Trying to optimise some of the imports in paramak

Types of changes

What types of changes does your code introduce to the Paramak? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

@Shimwell what do you think?

codecov[bot] commented 3 years ago

Codecov Report

Merging #840 (4b6a956) into develop (79c2a04) will increase coverage by 0.00%. The diff coverage is 95.23%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #840   +/-   ##
========================================
  Coverage    94.67%   94.67%           
========================================
  Files           75       75           
  Lines         5390     5393    +3     
========================================
+ Hits          5103     5106    +3     
  Misses         287      287           
Impacted Files Coverage Δ
paramak/neutronics_utils.py 84.82% <88.88%> (+0.10%) :arrow_up:
paramak/parametric_shapes/extruded_circle_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/rotate_circle_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/sweep_circle_shape.py 100.00% <100.00%> (ø)
paramak/parametric_shapes/sweep_mixed_shape.py 100.00% <100.00%> (ø)
paramak/shape.py 97.85% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79c2a04...4b6a956. Read the comment docs.

RemDelaporteMathurin commented 3 years ago

@Shimwell I don't think I'll be able to continue working on this a lot. Shall I close/merge this and we'll try and take up the work sometime in the future?

shimwell commented 3 years ago

Sorry yes, lets get this merged