Closed shimwell closed 3 years ago
Merging #842 (34b69a5) into develop (f38485d) will increase coverage by
2.85%
. The diff coverage is67.00%
.
@@ Coverage Diff @@
## develop #842 +/- ##
===========================================
+ Coverage 94.68% 97.53% +2.85%
===========================================
Files 75 72 -3
Lines 5401 4750 -651
===========================================
- Hits 5114 4633 -481
+ Misses 287 117 -170
Impacted Files | Coverage Δ | |
---|---|---|
paramak/shape.py | 97.02% <33.33%> (-0.86%) |
:arrow_down: |
paramak/reactor.py | 90.70% <50.00%> (-1.18%) |
:arrow_down: |
paramak/utils.py | 89.71% <67.77%> (-7.60%) |
:arrow_down: |
paramak/__init__.py | 100.00% <100.00%> (ø) |
|
paramak/parametric_reactors/iter_paper_2020.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e459768...34b69a5. Read the comment docs.
Proposed changes
After many many attempts I think this is the best split of the two packages so far. This is still under development as it requires another package that doesn't exist quite yet. So not ready to be merged as we would lose a lot of functionality.
This removes neutronics simulations for the paramak. This makes the parmak easier to install, distribute for users that just want the geometry. It is also easier to maintain for the developers.
I am hoping this makes a conda install easier
Types of changes
Checklist