Open shimwell opened 3 years ago
Merging #843 (eb298c0) into develop (ddcfff3) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #843 +/- ##
========================================
Coverage 94.68% 94.68%
========================================
Files 75 75
Lines 5404 5404
========================================
Hits 5117 5117
Misses 287 287
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ddcfff3...eb298c0. Read the comment docs.
Proposed changes
This is not ready for the review
This is my first partly working conda install, it can be built using
This is build but failing neutronics tests. So I shall pick this up again once neutronics has been removed
Types of changes
What types of changes does your code introduce to the Paramak? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...