ukaea / paramak

Create parametric 3D fusion reactor CAD models
https://paramak.readthedocs.io/en/main/
37 stars 12 forks source link

added gap size #845

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

Proposed changes

This adds the ability to add a gap between the TF and the divertor.

ball_reactor(2)

Types of changes

Checklist

shimwell commented 3 years ago

@katie-taylor @billingsley-john I think this is ready for review

billingsley-john commented 3 years ago

Looks like a very useful addition!

codecov[bot] commented 3 years ago

Codecov Report

Merging #845 (b53c7fe) into develop (e459768) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #845   +/-   ##
========================================
  Coverage    94.68%   94.68%           
========================================
  Files           75       75           
  Lines         5401     5402    +1     
========================================
+ Hits          5114     5115    +1     
  Misses         287      287           
Impacted Files Coverage Δ
paramak/parametric_reactors/ball_reactor.py 98.91% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e459768...b53c7fe. Read the comment docs.