search

ukautz / wart

Extends the Pimple dependency injection container and provides auto class resolving, instantiation and (constructor) injection
14 stars 1 forks source link

Pimple 3+ #3

Open ghost opened 9 years ago

ghost commented 9 years ago

Does this not work with Pimple 3 and above?

meetmatt commented 6 years ago

It can work, but requires a BC break: Wart has to extend from Container instead of Pimple. I've created a separate branch, tag and package if you need Pimple 3: https://github.com/meetmatt/wart/tree/3.0 https://github.com/meetmatt/wart/tree/3.0.0 https://packagist.org/packages/meetmatt/wart#3.0.0 Probably it could be a main branch, but I am not an original creator of this package

thewunder commented 5 years ago

@meetmatt How about doing a pull request, and @ukautz could do a release, I have a large project using pimple 3 and this would be the easiest way to add auto-resolution

meetmatt commented 5 years ago

@thewunder sure, I can easily do it. Will get back to this topic after working hours.

meetmatt commented 5 years ago

@thewunder @ukautz here's the PR: https://github.com/ukautz/wart/pull/5 Let me know if you need anything more :)