ukdtom / WebTools.bundle

WebTools is a collection of tools for Plex Media Server. Like the Unsupported AppStore (UAS)
https://forums.plex.tv/discussion/288191
Mozilla Public License 2.0
1.3k stars 170 forks source link

playlists: filename extension should be m3u8 #365

Closed OttoKerner closed 7 years ago

OttoKerner commented 7 years ago

Currently, the filename extension of a downlaoded playlist is SRT A case of copy & paste error I guess.

This should be .m3u (or more correctly .m3u8, because the playlist file is UTF-8 encoded)

ukdtom commented 7 years ago

Huh....It's .m3u8 extention for me

Can you verify with another browser?

ukdtom commented 7 years ago

Just tested via TeamViewer for @trumpy81 , and downloaded playlist also had the extention .m3u8

trumpy81 commented 7 years ago

I just tested it in FF 55.0.1 and the file has no extension at all. It worked OK in Chrome though.

I tested it in Chrome with WT on the PC again and it still adds the .m3u8 extension as it should.

I tried it in FF with WT on the Syno and noticed that it also does not provide the full playlist name if there are spaces in the name.

EG: Playlist name = David Gilmour - About Face, but in FF it wants to download as David, with no extension etc.

And just a reminder, it fails when attempting to download smart playlists imported/added by iTunes.

ukdtom commented 7 years ago

So a FF issue perhaps... @OttoKerner What browser did you use?

ukdtom commented 7 years ago

@OttoKerner and @trumpy81

I've updated the translation build on Github with a potential fix, so if you guys could verify it would be nice

trumpy81 commented 7 years ago

Tested with FF and WT on PC, No problem, full name and .m3u8 extension. Tested with FF and WT on NAS, No problem, full name and .m3u8 extension.

ukdtom commented 7 years ago

Thanks Andy. Will close this for now then. @OttoKerner Feel free to reopen, if still a problem

OttoKerner commented 7 years ago

I am using Firefox. I seem to remember that I tested first the 'download of a subtitle' feature. Maybe the filename extension got 'stuck' somehow?

Right now I cannot re-create this because the subtitle export doesn't work.

ukdtom commented 7 years ago

Ref #373

ukdtom commented 7 years ago

@OttoKerner Updated translate build with a fix for Sub downloads

OttoKerner commented 7 years ago

This appears to work correctly in the latest version.

ukdtom commented 7 years ago

Thanks for testing